feat!: enable cycles ledger unconditionally - #3796
Merged
Merged
Conversation
viviveevee
commented
Jun 20, 2024
| @@ -1,4 +1,3 @@ | |||
| // TODO(FI-1022): Import types from cycles ledger crate once available | |||
Contributor
Author
There was a problem hiding this comment.
Ticket was closed without action. There will be no such crate
viviveevee
marked this pull request as ready for review
June 20, 2024 08:36
THLO
approved these changes
Jun 21, 2024
ghost
suggested changes
Jun 24, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
As I understand it, the cycles ledger is now enabled all the time, not just by default.
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
viviveevee
changed the title
ghost
approved these changes
Jun 25, 2024
viviveevee
enabled auto-merge (squash)
June 26, 2024 07:05
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that the CMC on mainnet is properly configured we can move forward with the cycles ledger. This PR enables the cycles ledger fully.
How Has This Been Tested?
existing e2e
Checklist: